stop render consent screen when user is not logged-in #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nov
force-pushed
the
fix/double_render_on_prompt_consent
branch
from
35c688a
to
46653c5
Compare
nov
force-pushed
the
fix/double_render_on_prompt_consent
branch
from
46653c5
to
8228ca7
Compare
nbulaj
approved these changes
Jan 17, 2023
|
ok, added changelog. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current
doorkeeper-openid_connectimplementation always renders consent screen whenprompt=consentis requested.however, user can be non-authenticated status when requesting.
in that case, application tend to redirect to login page, and it conflicts with rendering consent screen, and results in
AbstractController::DoubleRenderErrorerror.this pull request stop rendering consent screen when user is not authenticated, and will render consent screen after the user is authenticated.