Minor change to improve support for Parcel/SWC #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parcel is currently [unable to perform static analysis](parcel-bundler/parcel#7904) on the `in` operator applied to `process.env`, for the purposes of bundling the module. (Parcel is a front-end to SWC, so this most likely affects SWC as well.) Would you mind making this very minor change? It should work exactly the same - `enabled` is `true` by default, so `FORCE_COLOR` only has an effect when set to exactly `0`. It's a bit simpler and avoids mutations, so maybe a bit easier to read anyhow. 🙂
mindplay-dk
added a commit
to mindplay-dk/inertion
that referenced
this pull request
Apr 12, 2022
|
thank you, and sorry for taking so long to merge! |
|
published and released as 4.1.2. thanks again @mindplay-dk! |
|
Ah, well, thanks - but they actually fixed the issue, which only surfaced another issue. Besides, it doesn't look like the generated the ANSI color codes actually work properly in browsers to begin with: #53. With no color library actually supporting this, it looks like I may be the only person who needs this or cares - probably most people would just build a dedicated HTML front-end for whatever they're building instead, so maybe that's what I have to do. |
I commented on that issue. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parcel is currently unable to perform static analysis on the
inoperator applied toprocess.env, for the purposes of bundling the module. (Parcel is a front-end to SWC, so this most likely affects SWC as well.)Would you mind making this very minor change?
It should work exactly the same -
enabledistrueby default, soFORCE_COLORonly has an effect when set to exactly0.It's a bit simpler and avoids mutations, so maybe a bit easier to read anyhow. 🙂