Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use struct type instead of array for ros2 messages #349

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Use struct type instead of array for ros2 messages #349

merged 3 commits into from
Sep 6, 2023

Conversation

haixuanTao
Copy link
Collaborator

Small suggestions to make the example even more readable.

phil-opp
phil-opp approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/python-ros2-dataflow/control_node.py Outdated Show resolved Hide resolved
examples/python-ros2-dataflow/random_turtle.py Show resolved Hide resolved
Base automatically changed from typed-ros2-example to main September 6, 2023 08:27
@phil-opp phil-opp merged commit f5673ff into main Sep 6, 2023
16 checks passed
@phil-opp phil-opp deleted the ros2-examples-suggestions branch September 6, 2023 12:24
@haixuanTao haixuanTao mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haixuanTao @phil-opp