Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small logging improvements #537

Merged
merged 2 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion binaries/daemon/src/node_communication/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,10 @@ impl Listener {
self.report_drop_tokens(drop_tokens).await?;

if dropped > 0 {
tracing::debug!("dropped {dropped} inputs because event queue was too full");
tracing::debug!(
"dropped {dropped} inputs of node `{}` because event queue was too full",
self.node_id
);
}
Ok(())
}
Expand Down
2 changes: 1 addition & 1 deletion binaries/daemon/src/spawn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
io::{AsyncBufReadExt, AsyncWriteExt},
sync::{mpsc, oneshot},
};
use tracing::{debug, error};

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Bench (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Bench (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Clippy

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / CLI Test (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / CLI Test (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Bench (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Bench (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Bench (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Bench (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / CLI Test (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

Check warning on line 35 in binaries/daemon/src/spawn.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `debug`

/// clock is required for generating timestamps when dropping messages early because queue is full
pub async fn spawn_node(
Expand Down Expand Up @@ -443,7 +443,7 @@
output.push('\n');
output
});
debug!("{dataflow_id}/{} logged:\n{formatted}", node.id.clone());
tracing::trace!("{dataflow_id}/{} logged:\n{formatted}", node.id.clone());
// Make sure that all data has been synced to disk.
let _ = file
.sync_all()
Expand Down
6 changes: 6 additions & 0 deletions libraries/core/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ impl std::fmt::Display for NodeId {
}
}

impl AsRef<str> for NodeId {
fn as_ref(&self) -> &str {
&self.0
}
}

#[derive(
Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord, Serialize, Deserialize, JsonSchema,
)]
Expand Down
Loading