Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix event_as_input bug #556

Merged
merged 1 commit into from
Jun 15, 2024
Merged

fix event_as_input bug #556

merged 1 commit into from
Jun 15, 2024

Conversation

XxChang
Copy link
Collaborator

@XxChang XxChang commented Jun 15, 2024

The old event_as_input referred to data: ArrayData as GenericBinaryArray, it's always failed when calling.

I fix it up.

@XxChang XxChang requested a review from phil-opp June 15, 2024 05:14
phil-opp
phil-opp approved these changes Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot!

@phil-opp phil-opp merged commit 62d1343 into main Jun 15, 2024
18 checks passed
@phil-opp phil-opp deleted the fix_cxx_read_input_bug branch June 15, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XxChang @phil-opp