-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform custom PyEvent into standard python dictionary for easier d… #557
Conversation
…ebuggability. Currently having a custom PyEvent make debugging very hard as fields are hidden within the class PyEvent that is defined within Rust Code. Python user are getting really confused about this obscure class. This PR transforms the class into a standard python dictionary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
Is this a breaking change or does existing code continue to work?
Ezisting code will continue to work! Except for ros2-bridge where you will have to change |
Ok great! The ROS2 bridge change is fine I think given that we still consider it experimental. |
Yup. It makes the current implementation of the ros2-bridge closer to the rest of dora API |
1a15af7
to
a8d4c07
Compare
…ebuggability.
Currently having a custom PyEvent make debugging very hard as fields are hidden within the class PyEvent that is defined within Rust Code.
Python user are getting really confused about this obscure class.
This PR transforms the class into a standard python dictionary.
It also makes external event and dora event expose the same user API meaning to access the data people just use:
data = event["value"]
instead ofdata = event.inner()