Fix dora list listing twice a stopping dataflow when using multiple daemon. #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
reviewed
Sep 27, 2024
Comment on lines
+274
to
+277
| println!( | ||
| "removed machine id: {machine_id} from dataflow: {:#?}", | ||
| dataflow.uuid | ||
| ); |
There was a problem hiding this comment.
Could you change this println to a tracing::info or tracing::debug?
Comment on lines
+283
to
+286
| dataflow_results | ||
| .entry(uuid) | ||
| .or_default() | ||
| .insert(machine_id, result); |
There was a problem hiding this comment.
Could you clarify why you moved this statement into the if body too? We want to store the results of all machines, not just the last one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, When a daemon stop it sends a message to the coordinator which will log it as an archived dataflow even though not every daemon has stopped within the dataflow.
This PR should fix this issue.