Rework raw operator API on top of safer-api crate Allows a higher-level interface
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a higher-level interface
…safer-ffi` Requires removing the lifetime of the `SendOutput` type. We now use a `'static` Arc-owned closure instead. To make sure that all types show up in the C header files that we'll generate, we make sure that all the top-level types use `#[repr(C)]` instead of `#[repr(transparent)]`.
haixuanTao
approved these changes
Sep 7, 2022
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
safer-fficrate to define a higher-level operator API.The foundation of the new API is a new
dora-operator-api-typescrate, which defines C-compatible types for inputs, outputs, and the different functions. These types are then used by both thedora-operator-apiandruntimecrates. This way, we can prevent undefined behavior caused by mismatched types. To also prevent type mismatch problems in the C-API, we now autogenerate aoperator_types.hheader file based on the types crate.This change will make it much easier to add additional metadata to inputs and outputs.