Make PublishSample an owned type and change output API to 3-step process
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
force-pushed
the
zero-copy-owned-sample
branch
2 times, most recently
from
d64c9b7
to
a5df665
Compare
…ocess Instead of passing a closure, we now `prepare` the output first, then write the data, and finally send it out. This should make it possible to enable zero-copy send operations also in Rust/C operators and C nodes since we avoid the type and lifetime complexity that an additional closure argument would cause.
phil-opp
force-pushed
the
zero-copy-owned-sample
branch
from
a5df665
to
e765128
Compare
16 tasks
Merged
|
This is no longer needed since we're now using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing a closure, we now
preparethe output first, then write the data, and finally send it out. This should make it possible to enable zero-copy send operations also in Rust/C operators and C nodes since we avoid the type and lifetime complexity that an additional closure argument would cause.This is a draft because it reqiures an experimental
SampleMutArcinterface oficeoryx-rs. I created a PR at eclipse-iceoryx/iceoryx-rs#61 to propose this newArc-based interface upstream.