Improve change detection for feature branches #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation for
pushtriggers tried to detect changes against the most recent commit on the branch before the push. This worked well for long-lived branches like master. However it didn't work well for feature branches.If you want to run CI jobs on every push to feature branch (before pull request is opened), it doesn't make sense to detect changes against same feature branch. Instead change detection should be done against the repository base branch (e.g. master).
This PR changes the default behavior for feature branches to run change detection against the repository default branch.
It also adds
basethat can be used to provide alternative base reference.Fixes #15