Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ✅ instead of ✔️ for better cross platform look #199

Closed
petrdvorak opened this issue Oct 5, 2022 · 1 comment
Closed

Use ✅ instead of ✔️ for better cross platform look #199

petrdvorak opened this issue Oct 5, 2022 · 1 comment

Comments

@petrdvorak
Copy link
Contributor

You currently use:

export const Icon = {
  skip: '✖️', // ':heavy_multiplication_x:'
  success: '✔️', // ':heavy_check_mark:'
  fail: '❌' // ':x:'
}

This is how it looks on Mac:

Screenshot 2022-10-05 at 21 46 28

I suggest using:

export const Icon = {
  skip: '✖️', // ':heavy_multiplication_x:'
  success: '✅', // ':white_check_mark:'
  fail: '❌' // ':x:'
}

See comparison:

@petrdvorak
Copy link
Contributor Author

petrdvorak commented Oct 5, 2022

... the skipped test is also probably better represented with the ⚪ emoticon. It evokes emptiness, just like looking at the empty summer sky over Tatras...

dharmendrasha added a commit that referenced this issue Nov 2, 2022
Fix #199: Use ✅ instead of ✔️ for better cross platform look
dorny added a commit that referenced this issue Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant