Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout and upload-artifact actions versions #419

Merged

Conversation

Akaame
Copy link
Contributor

@Akaame Akaame commented Apr 8, 2024

No description provided.

@jozefizso
Copy link
Collaborator

It is not apparent from the build checks, but these changes are failing the workflow: https://github.com/dorny/test-reporter/actions/runs/8596798196

@jozefizso jozefizso marked this pull request as draft April 8, 2024 08:26
@Akaame
Copy link
Contributor Author

Akaame commented Apr 8, 2024

@jozefizso interesting, I do not think it is related to my changeset actually. Am I the first outside contributor who had auth problems for the download artifact action in this pipeline?

Edit: looking at the history it seems that I am the only one with the problem. I will create a minimal documentation change instead to see if the problem is with my changeset or some sort of weird auth issue.

@Akaame
Copy link
Contributor Author

Akaame commented Apr 8, 2024

#420 created this and just realized the CI action ignores the *.md.

@cclauss
Copy link
Contributor

cclauss commented Apr 9, 2024

Related to:

I confirm this problem. I bet that if you revert these changes then things will work again.

-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4

@abelbraaksma
Copy link
Contributor

abelbraaksma commented Apr 13, 2024

Related: #343

TLDR: artifacts@v4 is NOT compatible with artifacts@v3 and may lead to auth issues, among others. See https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

@Akaame
Copy link
Contributor Author

Akaame commented Apr 17, 2024

@jozefizso I added a hail-mary fix attempt for the solution after diving into @abelbraaksma has provided and reading this Reddit comment. IDK if this is the correct direction but I think we might as well give it a try.

TLDR: providing Authorization header to the Azure Blob Storage API was superfluous and had to be removed in the case above.

@Akaame Akaame marked this pull request as ready for review May 8, 2024 06:26
@Akaame
Copy link
Contributor Author

Akaame commented May 8, 2024

Would it be possible for us to give the proposed solution a try?

@jozefizso jozefizso force-pushed the chore/version-updates-for-gh-actions-and-docs branch from f47cc9c to 4a41820 Compare May 18, 2024 11:56
@jozefizso jozefizso self-assigned this May 18, 2024
@jozefizso jozefizso added the enhancement New feature or request label May 18, 2024
@jozefizso jozefizso added this to the v2.0.0 milestone May 18, 2024
@jozefizso jozefizso merged commit 653ebca into dorny:main May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants