generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support displaying test results in markdown using GitHub Actions Job Summaries #463
Merged
jozefizso
merged 14 commits into
dorny:main
from
ritchxu:ritchxu/support-actions-summary
Jun 25, 2024
Merged
Support displaying test results in markdown using GitHub Actions Job Summaries #463
jozefizso
merged 14 commits into
dorny:main
from
ritchxu:ritchxu/support-actions-summary
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip markdown file
tal-y-roni
approved these changes
Jun 18, 2024
jozefizso
requested changes
Jun 25, 2024
Hi @ritchxu, thanks for making this PR. Overall, it looks good. Could you fix the regression in the rendering of the test results? |
Thanks for the feedback @jozefizso! Comments addressed and conflicts resolved ✅ |
jozefizso
approved these changes
Jun 25, 2024
Thanks for your contribution @ritchxu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a duplicate of a standing PR #383, with one extra commit that addresses a comment #383 (comment)
Opt for not updating
main
directly based on this feedback #383 (comment)