Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full URL to link test suites #89

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Use full URL to link test suites #89

merged 2 commits into from
Mar 31, 2021

Conversation

dorny
Copy link
Owner

@dorny dorny commented Mar 31, 2021

GitHub UI for some unknown reason navigates user to check run with check_suite_focus=true query argument. With this argument unfortunately navigation to document ID with #something doesn't work.

This patch tries to fix it by using full URL.
If user has the check_suite_focus=true URL it will cause reload of the page.
Afterwards navigation within document should work normally.

GitHub UI for some unknown reason navigates user to check run with `check_suite_focus=true` query argument. With this argument unfortunately navigation to document ID with `#something` doesn't work
Adds full URL in place previous commit missed
@dorny dorny merged commit 39f7ac7 into dev Mar 31, 2021
@dorny dorny deleted the fix-suite-links branch March 31, 2021 21:33
@dorny dorny mentioned this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant