Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return icd-10 codesystem version #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreakreichgauer
Copy link
Contributor

@andreakreichgauer andreakreichgauer commented Oct 9, 2023

Ticket 🎫

This closes #90

BREAKING CHANGE: changes the return type of the API search results to FuseResult<Fhir.CodeableConcept>. 🚨

Description 📖

This PR changes the API return type from FuseResult<Fhir.CodesystemConcept> to FuseResult<Fhir.CodeableConcept>. The reason behind this was, that the API should return a system url such as http://fhir.de/CodeSystem/bfarm/icd-10-gm and a version (currently 2024) to specify which icd-10 catalogue was used for the returned search results.

How to Test? 🧪

Setup locally and request e.g. https://dotbase.local/api/icd10/?search=parkinson.
Check that the result items match CodeableConcepts and includes a system url and a version.

Is there something controversial ? 🚨

This needs to be changed in medical-dashboard too.

Checklist ✅

  • My changes generate no new warnings
  • Made corresponding changes to the documentation if applicable
  • Commented my code, particularly in hard-to-understand areas if applicable
  • Performed a self-review of my own changes
  • Added relevant unit tests

@dotbase-bot dotbase-bot modified the milestones: next, v5.0.3 Nov 16, 2023
@dotbase-bot dotbase-bot self-assigned this Dec 19, 2023
@dotbase-bot dotbase-bot requested a review from a team December 19, 2023 22:05
@dotbase-bot dotbase-bot modified the milestones: v5.0.4, next Dec 21, 2023
@dotbase-bot dotbase-bot modified the milestones: v5.0.5, next, v5.0.6 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Codesystem url and version in api results
2 participants