Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templater Builder: Fixing Wrong Classes Deletion #25926

Closed
fmontes opened this issue Aug 28, 2023 · 5 comments · Fixed by #25928, #25935 or #25968
Closed

Templater Builder: Fixing Wrong Classes Deletion #25926

fmontes opened this issue Aug 28, 2023 · 5 comments · Fixed by #25928, #25935 or #25968
Assignees
@zJaaal @rjvelazco
Labels
Doc : Needs Doc OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.09.6 Release Template Builder Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Aug 28, 2023 •
edited
Loading

Problem Statement

In templater builder when remove classes from box and rows it remove the wrong one.

Steps to Reproduce

  1. Edit a template
  2. Add classes to box or row
  3. Edit the classes and remove the first one
  4. See the error how to delete the last one.
Kapture.2023-08-28.at.16.41.36.mp4

Acceptance Criteria

  1. User neends to be able to delete the clicked chip
  2. System should remove the correct class
  3. Remove the chip from the box or rows

External Links

N/A

Assumptions & Initiation Needs

N/A

Quality Assurance Notes & Workarounds

N/A
@zJaaal zJaaal self-assigned this Aug 29, 2023
@zJaaal zJaaal linked a pull request Aug 29, 2023 that will close this issue
Fix #25926: Template Builder fixing wrong classes deletion #25928
Merged
fmontes pushed a commit that referenced this issue Aug 29, 2023
@zJaaal
Fix #25926: Template Builder fixing wrong classes deletion (#25928)
e894bb1 
* dev (add style classes module): refactor to support remove any class

* fix (template builder story): console error due to missing import
@fmontes fmontes linked a pull request Aug 29, 2023 that will close this issue
Fix #25926 Reimplement the autocomplete component #25935
Merged
3 tasks
@rjvelazco
Copy link
Contributor

Faild Internal QA

  • Tested on master

Case 1: Deleting a duplicate class deletes all classes

Steps to Reproduce:

  1. Edit a template
  2. Add classes to box or row
  3. Add the following classes: class1, class2, class3, class1
  4. Deleted the last class1
  5. See how that action deletes all the classes.

Case 2: Hit delete deletes all classes instead of the last one.

Steps to Reproduce:

  1. Edit a template
  2. Add classes to box or row
  3. Add the following classes: class1, class2, class3
  4. Hit delete without saving or closing the dialog.
  5. See how that action deletes all the classes.
Screen.Recording.2023-08-29.at.4.05.20.PM.mov

fmontes added a commit that referenced this issue Aug 30, 2023
@fmontes @zJaaal
Fix #25926 Reimplement the autocomplete component (#25935)
86dd5d1 
* Reimplement the autocomplete component

* dev (add styles autocomplete): enhance functionality

* Fix filtering and styling.

* Fix the filtering and language messages

* Add tests for JsonClassesService

* Test are not running

* fix (add styles dialog): now tests are running

* Fix tests

* Update mocks

---------

Co-authored-by: Jalinson Diaz <[email protected]>
@rjvelazco rjvelazco self-assigned this Aug 31, 2023
@rjvelazco rjvelazco mentioned this issue Aug 31, 2023
Merged
@rjvelazco
Copy link
Contributor

Faild Internal QA

  • Tested on master

Steps to Reproduce

  1. Go to Template > Select a Template > Edit
  2. Try to edit box/rowCSS class. Note: Make sure you have predefined css classes.
  3. Open the dropdown.
  4. Use the up/down keys to navigate the options and go down.
  5. See the error. We do not scroll when using the keyboard.
internal-qa-issue-25926-fix-class-selector.mov

@rjvelazco
Copy link
Contributor

Update

The "AutoComplete component is not scrolling on arrow down" is a known issue of PrimeNg. It should be fixed once we update to the last version.

@rjvelazco
Copy link
Contributor

Passed Internal QA

  • Tested on master

Case 1: Not suggestions

Screen.Recording.2023-08-31.at.12.44.58.PM.mov

Case 2: Suggestions/Autocomplete

Screen.Recording.2023-08-31.at.1.14.16.PM.mov

fmontes pushed a commit that referenced this issue Aug 31, 2023
@rjvelazco
Fix #25926 Templater Builder: Fixing link target
97133ca
fmontes pushed a commit that referenced this issue Aug 31, 2023
@zJaaal @fmontes
Fix #25926: Template Builder fixing wrong classes deletion (#25928)
3e02dbd 
* dev (add style classes module): refactor to support remove any class

* fix (template builder story): console error due to missing import
fmontes added a commit that referenced this issue Aug 31, 2023
@fmontes @zJaaal
Fix #25926 Reimplement the autocomplete component (#25935)
fb93718 
* Reimplement the autocomplete component

* dev (add styles autocomplete): enhance functionality

* Fix filtering and styling.

* Fix the filtering and language messages

* Add tests for JsonClassesService

* Test are not running

* fix (add styles dialog): now tests are running

* Fix tests

* Update mocks

---------

Co-authored-by: Jalinson Diaz <[email protected]>
fmontes pushed a commit that referenced this issue Aug 31, 2023
@rjvelazco @fmontes
Fix #25926 Templater Builder: Fixing link target
a4fec3b
fmontes added a commit that referenced this issue Aug 31, 2023
@fmontes @zJaaal
@rjvelazco @manuelrojas
Cherry pick template issues for pre release (#25971)
5df882d 
* Fix #25917: Template Builder file containers were saving with Identifier instead of Path (#25920)

* dev (gridstack utils): add getContainerReference

* dev (template builder store): implement getContainerReference

* fix (palette content type module): add DotMessagePipe import

* feedback (template builder): moved getContainerReference from utils to box component

* feedback (template builder box test): enhance testing

* fix (containers mock): fix merge errors

* Fix #25937: Template Builder Enhancing error and request handling (#25942)

* fix (template save and publish): enhancing error and request handling

* feedback (dot templates service): delete old save and publish

* fix (gridstack utils): EMPTY_ROWS_VALUE was being modified by reference

* Fix #25926: Template Builder fixing wrong classes deletion (#25928)

* dev (add style classes module): refactor to support remove any class

* fix (template builder story): console error due to missing import

* Fix #25926 Reimplement the autocomplete component (#25935)

* Reimplement the autocomplete component

* dev (add styles autocomplete): enhance functionality

* Fix filtering and styling.

* Fix the filtering and language messages

* Add tests for JsonClassesService

* Test are not running

* fix (add styles dialog): now tests are running

* Fix tests

* Update mocks

---------

Co-authored-by: Jalinson Diaz <[email protected]>

* Fix #25926 Templater Builder: Fixing link target

* Fixing test (#25911)

---------

Co-authored-by: Jalinson Diaz <[email protected]>
Co-authored-by: Rafael Velazco <[email protected]>
Co-authored-by: Manuel Rojas <[email protected]>
@bryanboza
Copy link
Member

Fixed, tested on master // Docker // FF

Note: We need to doc how to add the prediction on CSS classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

@rjvelazco rjvelazco

Labels
Doc : Needs Doc OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.09.6 Release Template Builder Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
4 participants
@fmontes @bryanboza @zJaaal @rjvelazco