-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(design system): font size inconsistencies with % and em units #30040
Merged
valentinogiardino
merged 8 commits into
master
from
issue-28724-fix-percentage-font-size-inconsistencies
Sep 18, 2024
Merged
fix(design system): font size inconsistencies with % and em units #30040
valentinogiardino
merged 8 commits into
master
from
issue-28724-fix-percentage-font-size-inconsistencies
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valentinogiardino
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
zJaaal,
rjvelazco and
KevinDavilaDotCMS
September 17, 2024 19:40
zJaaal
changed the title
chore(design system): fix font size inconsistencies with % and em units
fix(design system): font size inconsistencies with % and em units
Sep 17, 2024
zJaaal
requested changes
Sep 17, 2024
dotCMS/src/main/webapp/html/portlet/ext/cmsmaintenance/system_config.jsp
Outdated
Show resolved
Hide resolved
fmontes
approved these changes
Sep 17, 2024
hmoreras
approved these changes
Sep 17, 2024
rjvelazco
approved these changes
Sep 17, 2024
Quality Gate passedIssues Measures |
zJaaal
approved these changes
Sep 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 18, 2024
valentinogiardino
deleted the
issue-28724-fix-percentage-font-size-inconsistencies
branch
September 18, 2024 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
%
per variables in .scss filesem
per variables in .scss filesAdditional Info
This PR addresses inconsistencies in font sizes caused by the use of
%
andem
values. It focuses exclusively on.scss
files, ensuring that all font sizes are now defined using standard variables.Font sizes within HTML tags will be handled in a separate ticket if necessary. However, this PR includes fixes for two inline font sizes to resolve an IQA report.
Font size variables
Regex Used
%
:font-size\s*:\s*\d*\.?\d+%
em
:font-size\s*:\s*\d*\.?\d+em
Table for
%
replacementTable for
em
replacementConsiderations taken:
dot-edit-page-nav.component.scss
.edit-page-nav__item
font-size = 10px& > .fa
font-size = 1.25 * 10px = 12.5px$font-size-sm = 12px
rule-engine.scss
$font-size-sm = 12px
Screenshots
This PR fixes: #28724
This PR fixes: #28724