Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iqa comments #30172

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix iqa comments #30172

merged 1 commit into from
Sep 27, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Sep 27, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • When you have multiple Wysiwyg fields and switch between Wysiwyg and Code, the popup is displayed three times, one for each of the fields instead only for the field being modified ✅
  • We should not show the popup when switching from Wysiwyg to Code but only from Code to Wysiwyg. ✅
  • Remove the "HTML" word from the message in the popup ✅

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

This PR fixes: #28186

@oidacra oidacra linked an issue Sep 27, 2024 that may be closed by this pull request
Edit Contentlet: Allow User to Toggle Between WYSIWYG and Code Field #28186
Closed
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@oidacra oidacra added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 62799e6 Sep 27, 2024
12 checks passed
@oidacra oidacra deleted the issue-28186-switch-between-monaco-tynimce-fix-2 branch September 27, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmoreras hmoreras hmoreras approved these changes

@nicobytes nicobytes nicobytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Contentlet: Allow User to Toggle Between WYSIWYG and Code Field
3 participants
@oidacra @nicobytes @hmoreras