Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new template or config option to apollo-react to support urql #1575

Closed
RIP21 opened this issue Mar 26, 2019 · 3 comments · Fixed by #1814
Closed

Add new template or config option to apollo-react to support urql #1575

RIP21 opened this issue Mar 26, 2019 · 3 comments · Fixed by #1814
Labels
waiting-for-release Fixed/resolved, and waiting for the next stable release

Comments

@RIP21
Copy link
Contributor

RIP21 commented Mar 26, 2019

Please consider adding a special template or config for apollo-react generator to support
https://github.com/FormidableLabs/urql/
It's quite popular and will be nice to have.
@RIP21 RIP21 changed the title Add generators or config option to apollo-react to support urql Add new template or config option to apollo-react to support urql Mar 26, 2019
@dotansimha dotansimha mentioned this issue Mar 26, 2019
Closed
@mxstbr
Copy link
Contributor

mxstbr commented May 6, 2019 •
edited
Loading

Yes please, we really need this! I am starting to dig into this, will open a WIP PR soon. I'll likely focus on only hooks support initially as that's what we need the most.

cc @kitten the main maintainer of urql

mxstbr pushed a commit to mxstbr/graphql-code-generator that referenced this issue May 6, 2019
Initial urql support (only hooks)
a9f865c 
Implements hooks support for FormidableLabs/urql users.

Ref dotansimha#1575
@mxstbr mxstbr mentioned this issue May 6, 2019
Merged
4 tasks
dotansimha pushed a commit that referenced this issue May 7, 2019
@mxstbr @dotansimha
Urql support (#1814)
bac0e05 
* Initial urql support (only hooks)

Implements hooks support for FormidableLabs/urql users.

Ref #1575

* Fix urql options

* Add support for components to urql generator

* Fix TypeScript generated types

* Cleanup

* Fixes component code generation
@dotansimha dotansimha reopened this May 7, 2019
@dotansimha dotansimha added the waiting-for-release Fixed/resolved, and waiting for the next stable release label May 7, 2019
@dotansimha
Copy link
Owner

Thank you @mxstbr ! Your PR is merged, and if someone wants to try it before the stable release, you can use 1.1.4-alpha-b8bdef27.12.
(also, keeping open until we'll release a new version)

@dotansimha
Copy link
Owner

Available in 1.2.0. Thanks @mxstbr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting-for-release Fixed/resolved, and waiting for the next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Urql support mxstbr/graphql-code-generator
3 participants
@dotansimha @RIP21 @mxstbr