Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] upgrade graphiql deps #3279

Merged
merged 5 commits into from
May 17, 2024
Merged

[graphiql] upgrade graphiql deps #3279

merged 5 commits into from
May 17, 2024

Conversation

EmrysMyrddin
Copy link
Collaborator

@EmrysMyrddin EmrysMyrddin commented May 17, 2024

This is a rebase of #3193

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: f00628f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@EmrysMyrddin
Copy link
Collaborator Author

@bgentry Hi! sorry for the very late response. Since I don't have the rights to force push on your fork, I had to create a new branche here. If you want, you can reset your branch on mine, so that you appear as the PR author :-)

Copy link
Contributor

github-actions bot commented May 17, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented May 17, 2024

💻 Website Preview

The latest changes are available as preview in: https://dd941f26.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented May 17, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 385682     ✗ 0     
     data_received................................: 1.6 GB  13 MB/s
     data_sent....................................: 78 MB   649 kB/s
     http_req_blocked.............................: avg=1.54µs   min=1.01µs   med=1.37µs   max=260.63µs p(90)=2.03µs   p(95)=2.23µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=134.9µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=400.44µs min=231.19µs med=355.3µs  max=24ms     p(90)=557.66µs p(95)=583.67µs
       { expected_response:true }.................: avg=400.44µs min=231.19µs med=355.3µs  max=24ms     p(90)=557.66µs p(95)=583.67µs
     ✓ { mode:graphql-jit }.......................: avg=301.73µs min=231.19µs med=279.87µs max=18.15ms  p(90)=309.2µs  p(95)=321.97µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=586.48µs min=483.23µs med=556.71µs max=10.21ms  p(90)=615.68µs p(95)=658.62µs
     ✓ { mode:graphql-response-cache }............: avg=377.54µs min=300.13µs med=357.04µs max=9.67ms   p(90)=386.83µs p(95)=398.24µs
     ✓ { mode:graphql }...........................: avg=398.79µs min=306.27µs med=365.07µs max=24ms     p(90)=414.21µs p(95)=446.41µs
     http_req_failed..............................: 0.00%   ✓ 0          ✗ 192841
     http_req_receiving...........................: avg=33.85µs  min=16.62µs  med=33.84µs  max=2.4ms    p(90)=39.28µs  p(95)=41.49µs 
     http_req_sending.............................: avg=8.67µs   min=6.1µs    med=7.69µs   max=815.13µs p(90)=11.21µs  p(95)=12.43µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=357.9µs  min=196.15µs med=313.47µs max=23.85ms  p(90)=514.88µs p(95)=539.39µs
     http_reqs....................................: 192841  1606.98517/s
     iteration_duration...........................: avg=617.33µs min=407.78µs med=568.4µs  max=24.79ms  p(90)=774.8µs  p(95)=804.77µs
     iterations...................................: 192841  1606.98517/s
     vus..........................................: 1       min=1        max=1   
     vus_max......................................: 2       min=2        max=2   

Copy link
Contributor

github-actions bot commented May 17, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
graphql-yoga-cloud-run-guide 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/apollo-link 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 4.3.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
graphql-yoga 5.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs-federation 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 2.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-jwt 2.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 5.1.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 3.6.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 3.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 5.4.0-alpha-20240517193238-f00628f0 npm ↗︎ unpkg ↗︎

@bgentry
Copy link
Contributor

bgentry commented May 17, 2024

Thank you, I just wasn’t sure how to get this resolved so I appreciate it. No need to change anything, seems I’m already listed as co author on the commits anyway 🙏🏻

@EmrysMyrddin
Copy link
Collaborator Author

@bgentry Ok cool! I've updated the integration tests, it should be good to merge now :-) Just waiting for the CI

Thank you again for the work! Very appreciated!

@EmrysMyrddin EmrysMyrddin merged commit 5a40b2b into main May 17, 2024
26 of 27 checks passed
@EmrysMyrddin EmrysMyrddin deleted the bg-graphiql-options branch May 17, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants