Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sofa): request in the context #3381

Merged
merged 3 commits into from
Jul 24, 2024
Merged

fix(sofa): request in the context #3381

merged 3 commits into from
Jul 24, 2024

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jul 23, 2024

Fix the existence of request in the context

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 79fedfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-sofa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Jul 23, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 428564      ✗ 0     
     data_received................................: 1.7 GB  15 MB/s
     data_sent....................................: 87 MB   721 kB/s
     http_req_blocked.............................: avg=1.38µs   min=992ns    med=1.26µs   max=258.47µs p(90)=1.77µs   p(95)=1.99µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=141.43µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=353.54µs min=212.43µs med=316.5µs  max=20.02ms  p(90)=455.26µs p(95)=475.09µs
       { expected_response:true }.................: avg=353.54µs min=212.43µs med=316.5µs  max=20.02ms  p(90)=455.26µs p(95)=475.09µs
     ✓ { mode:graphql-jit }.......................: avg=278.08µs min=212.43µs med=256.34µs max=20.02ms  p(90)=287.64µs p(95)=300.84µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=481.01µs min=397.14µs med=451.51µs max=9.11ms   p(90)=491.68µs p(95)=523.66µs
     ✓ { mode:graphql-response-cache }............: avg=334.65µs min=266.87µs med=316.08µs max=6.83ms   p(90)=349.37µs p(95)=360.18µs
     ✓ { mode:graphql }...........................: avg=357.4µs  min=267.92µs med=323.92µs max=13.77ms  p(90)=370.53µs p(95)=422.12µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 214282
     http_req_receiving...........................: avg=33.09µs  min=16.13µs  med=32.78µs  max=7.19ms   p(90)=38.19µs  p(95)=40.3µs  
     http_req_sending.............................: avg=7.76µs   min=5.82µs   med=6.96µs   max=366.66µs p(90)=10.34µs  p(95)=11.05µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=312.68µs min=178.7µs  med=276.41µs max=19.87ms  p(90)=414.17µs p(95)=431.82µs
     http_reqs....................................: 214282  1785.660421/s
     iteration_duration...........................: avg=555.35µs min=382.79µs med=514.33µs max=20.56ms  p(90)=660.11µs p(95)=686.31µs
     iterations...................................: 214282  1785.660421/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Jul 23, 2024

💻 Website Preview

The latest changes are available as preview in: https://7e8c2523.graphql-yoga.pages.dev

@ardatan ardatan merged commit a0e24fe into main Jul 24, 2024
34 checks passed
@ardatan ardatan deleted the sofa-context-request branch July 24, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant