Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default config for Prom metrics #3408

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Change default config for Prom metrics #3408

merged 2 commits into from
Aug 14, 2024

Conversation

dotansimha
Copy link
Owner

@dotansimha dotansimha commented Aug 14, 2024

By default, the following metrics are now enabled:

  • graphql_envelop_deprecated_field
  • graphql_envelop_request
  • graphql_envelop_request_duration
  • graphql_envelop_request_time_summary
  • graphql_envelop_phase_parse
  • graphql_envelop_phase_validate
  • graphql_envelop_phase_context
  • graphql_envelop_error_result
  • graphql_envelop_phase_execute
  • graphql_envelop_phase_subscribe
  • graphql_envelop_schema_change
  • graphql_yoga_http_duration

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: b2fd4e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-prometheus Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha dotansimha requested a review from n1ru4l August 14, 2024 08:40
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Aug 14, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 426466     ✗ 0     
     data_received................................: 1.7 GB  15 MB/s
     data_sent....................................: 86 MB   718 kB/s
     http_req_blocked.............................: avg=1.48µs   min=962ns    med=1.34µs   max=255.72µs p(90)=1.93µs   p(95)=2.12µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=137.21µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=352.61µs min=207.92µs med=315.54µs max=18.26ms  p(90)=455.58µs p(95)=473.98µs
       { expected_response:true }.................: avg=352.61µs min=207.92µs med=315.54µs max=18.26ms  p(90)=455.58µs p(95)=473.98µs
     ✓ { mode:graphql-jit }.......................: avg=280.35µs min=207.92µs med=259.74µs max=18.26ms  p(90)=288.96µs p(95)=300.11µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=477.36µs min=396.04µs med=452.31µs max=9.05ms   p(90)=489.75µs p(95)=512.78µs
     ✓ { mode:graphql-response-cache }............: avg=333.23µs min=261.29µs med=314.98µs max=8.44ms   p(90)=344.84µs p(95)=355.31µs
     ✓ { mode:graphql }...........................: avg=354.5µs  min=268.95µs med=323.42µs max=13.58ms  p(90)=364.71µs p(95)=398.68µs
     http_req_failed..............................: 0.00%   ✓ 0          ✗ 213233
     http_req_receiving...........................: avg=32.86µs  min=17.15µs  med=32.98µs  max=1.46ms   p(90)=38.45µs  p(95)=40.46µs 
     http_req_sending.............................: avg=8.12µs   min=6.09µs   med=7.29µs   max=469.61µs p(90)=10.68µs  p(95)=11.32µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=311.62µs min=174.51µs med=274.93µs max=18.13ms  p(90)=414.45µs p(95)=430.56µs
     http_reqs....................................: 213233  1776.91792/s
     iteration_duration...........................: avg=558µs    min=384.41µs med=517.47µs max=18.79ms  p(90)=664.99µs p(95)=687.43µs
     iterations...................................: 213233  1776.91792/s
     vus..........................................: 1       min=1        max=1   
     vus_max......................................: 2       min=2        max=2   

Copy link
Contributor

github-actions bot commented Aug 14, 2024

💻 Website Preview

The latest changes are available as preview in: https://d54136ca.graphql-yoga.pages.dev

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information should also be documented within the docs.

@dotansimha
Copy link
Owner Author

This information should also be documented within the docs.

Fixed, thanks!

@dotansimha dotansimha merged commit 88393b3 into main Aug 14, 2024
35 checks passed
@dotansimha dotansimha deleted the prom-defaults branch August 14, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants