Minimal API /3 #22941

Rick-Anderson · 2021-08-03T21:50:40Z

Fixes #22942

Internal review URL

aspnetcore/tutorials/min-web-api.md

aspnetcore/tutorials/min-web-api/samples/6.x/todo/Program.cs

davidfowl · 2021-08-04T14:25:13Z

aspnetcore/tutorials/min-web-api.md

+* Select the **Project** checkbox in the right pane and then select **Install**.
+* Follow the preceding instructions to add the following packages:
+  * `Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore`
+  * `MinimalValidation`


Not sure we want to show this in the tutorial? Do we @LadyNaggaga @DamianEdwards? Maybe we should show fluent validation instead?

These aren't in the box yet so, let's remove them. @DamianEdwards am I wrong ?

As @davidfowl says we could decide to show how to use FluentValidation or I could do some work on MinimalValidation and release that as a 1.0 and we could use that. Or we don't talk about validation at all in the tutorial as it's not something we provide in the box today. We know people will ask about it but we also know putting things in the tutorial is in ways an implicit blessing/statement of what we recommend. Likely requires more thought/discussion.

aspnetcore/tutorials/min-web-api.md

+
+Examine the `app.MapPut("/todoitems/{id}", ...` method:
+
+[!code-csharp[](min-web-api/samples/6.x/todo/Program.cs?name=snippet_put)]


Rick-Anderson · 2021-10-18T21:05:33Z

EDIT I've decided to keep Swagger and the weather forecast controller, then remove them in the next step

@rafikiassumani-msft @davidfowl @LadyNaggaga @DamianEdwards I suggest for this onboarding tutorial I have then uncheck Enable OpenAPI support. Otherwise the generated code goes from 4 lines to 43 lines. I think we should focus on minimal APIs and refer them to Swagger in a follow up tutorial.

Rick-Anderson · 2021-10-21T18:59:42Z

@rafikiassumani-msft I'm merging this at EOD unless you have changes. cc @LadyNaggaga

davidfowl · 2021-10-22T02:00:54Z

aspnetcore/tutorials/min-web-api.md

+  - No support for binding from forms. This includes binding <xref:Microsoft.AspNetCore.Http.IFormFile>. We plan to add support for `IFormFile` in the future.
+- No built-in support for validation. i.e. <xref:Microsoft.AspNetCore.Mvc.ModelBinding.Validation.IModelValidator>
+- No support for [application parts](xref:mvc/advanced/app-parts) or the [application model](xref:mvc/controllers/application-model). There's no way to apply or build your own conventions.
+- No built-in view rendering support. We recommend using Razor Pages for rendering views.


Link to the razor pages article

Rick-Anderson · 2021-10-23T00:23:10Z

@serpent5 please review on Monday but not before then.

Made requested changes and asked for new review last week

Rick-Anderson · 2021-10-23T00:37:03Z

@rafikiassumani-msft @LadyNaggaga @captainsafia I'm merging this EOD Monday.

serpent5

Let me know if you want me to turn down the verbosity for the next review. 😅

aspnetcore/tutorials/min-web-api.md

serpent5 · 2021-10-25T12:25:44Z

aspnetcore/tutorials/min-web-api.md

+## Differences between minimal APIs and APIs with controllers
+
+- No support for filters: For example, no support for  <xref:Microsoft.AspNetCore.Mvc.Filters.IAsyncAuthorizationFilter>, <xref:Microsoft.AspNetCore.Mvc.Filters.IAsyncActionFilter>, <xref:Microsoft.AspNetCore.Mvc.Filters.IAsyncExceptionFilter>, <xref:Microsoft.AspNetCore.Mvc.Filters.IAsyncResultFilter>,  and <xref:Microsoft.AspNetCore.Mvc.Filters.IAsyncResourceFilter>
+- No support for model binding. i.e. <xref:Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinderProvider>, <xref:Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder>. Support can be added with a custom binding shim.


Support can be added with a custom binding shim.

Is there somewhere we can send the reader to learn more about what this means?

aspnetcore/tutorials/min-web-api.md

serpent5 · 2021-10-25T12:28:31Z

aspnetcore/tutorials/min-web-api.md

+- 
+## Use JsonOptions
+
+The following code uses <xref:Microsoft.AspNetCore.Http.Json.JsonOptions>:


A couple of thoughts here:

The code that follows doesn't actually mention JsonOptions.

The section doesn't have much context. Should we call out that it's showing how to customise the JSON response, for example?

aspnetcore/tutorials/min-web-api.md

Co-authored-by: Kirk Larkin <[email protected]>

aspnetcore/tutorials/min-web-api.md

Co-authored-by: Kirk Larkin <[email protected]>

Rick-Anderson added 2 commits August 3, 2021 14:48

Minimal API /3

6651182

Minimal API /3

108deb9

Rick-Anderson marked this pull request as draft August 3, 2021 22:03

Rick-Anderson added 5 commits August 3, 2021 15:05

Minimal API /3

dd2a625

Minimal API /3

17b4aed

Minimal API /3

3c74ec9

Minimal API /3

c263771

Minimal API /3

ca4583c

davidfowl reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Show resolved Hide resolved

davidfowl reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Outdated Show resolved Hide resolved

davidfowl reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Outdated Show resolved Hide resolved

davidfowl reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api/samples/6.x/todo/Program.cs Outdated Show resolved Hide resolved

davidfowl reviewed Aug 4, 2021

View reviewed changes

Rick-Anderson added 3 commits August 4, 2021 07:42

react to draft feedback

3e56ae1

react to draft feedback

d0ee908

react to draft feedback

86bc32e

Rick-Anderson changed the title ~~Minimal API /3~~ Double Draft: Minimal API /3 Aug 4, 2021

LadyNaggaga reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Show resolved Hide resolved

LadyNaggaga reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Outdated Show resolved Hide resolved

LadyNaggaga reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Outdated Show resolved Hide resolved

Rick-Anderson added 2 commits August 4, 2021 08:53

react to draft feedback

c7b69ca

react to draft feedback

81c3ebd

halter73 reviewed Aug 4, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md

Examine the `app.MapPut("/todoitems/{id}", ...` method:

[!code-csharp[](min-web-api/samples/6.x/todo/Program.cs?name=snippet_put)]

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

Rick-Anderson added 7 commits August 4, 2021 11:19

react to draft feedback

343dcc9

work

ea9164f

work

5dfa3db

work

a3ba606

work

34bba36

VSC work

c8dbc9c

VSC work

77f9e8b

Rick-Anderson added 2 commits October 18, 2021 10:20

work

3f97a66

work

8fb2dbd

Rick-Anderson added 7 commits October 18, 2021 11:22

work

9524159

work

9d0e00f

work

cc2677a

work

3e5ccce

work

84e965c

work

b4b73d0

work

c4150aa

Rick-Anderson requested review from timheuer and LadyNaggaga October 19, 2021 17:54

work

be6248a

Rick-Anderson requested a review from davidfowl October 20, 2021 02:00

work

5eaf99e

work

f638f8f

davidfowl reviewed Oct 22, 2021

View reviewed changes

react to feedback

bf5d7af

Rick-Anderson mentioned this pull request Oct 23, 2021

Update link to Minimal APIs #23614

Closed

serpent5 reviewed Oct 25, 2021

View reviewed changes

Apply suggestions from code review

01231b7

Co-authored-by: Kirk Larkin <[email protected]>

serpent5 reviewed Oct 25, 2021

View reviewed changes

aspnetcore/tutorials/min-web-api.md Outdated Show resolved Hide resolved

Rick-Anderson and others added 2 commits October 25, 2021 13:22

Update aspnetcore/tutorials/min-web-api.md

05931bf

Co-authored-by: Kirk Larkin <[email protected]>

react to feedback

18db1d4

Rick-Anderson merged commit 95f4117 into main Oct 25, 2021

Rick-Anderson deleted the minAPI/ra/3 branch October 25, 2021 23:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimal API /3 #22941

Minimal API /3 #22941

Rick-Anderson commented Aug 3, 2021 •

edited

Loading

davidfowl Aug 4, 2021

LadyNaggaga Aug 4, 2021

DamianEdwards Aug 7, 2021

This comment was marked as resolved.

This comment was marked as resolved.

Rick-Anderson commented Oct 18, 2021 •

edited

Loading

Rick-Anderson commented Oct 21, 2021

davidfowl Oct 22, 2021

Rick-Anderson commented Oct 23, 2021

Rick-Anderson commented Oct 23, 2021

serpent5 left a comment •

edited

Loading

serpent5 Oct 25, 2021

serpent5 Oct 25, 2021 •

edited

Loading


		Examine the `app.MapPut("/todoitems/{id}", ...` method:

		[!code-csharp[](min-web-api/samples/6.x/todo/Program.cs?name=snippet_put)]

Minimal API /3 #22941

Minimal API /3 #22941

Conversation

Rick-Anderson commented Aug 3, 2021 • edited Loading

davidfowl Aug 4, 2021

Choose a reason for hiding this comment

LadyNaggaga Aug 4, 2021

Choose a reason for hiding this comment

DamianEdwards Aug 7, 2021

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Rick-Anderson commented Oct 18, 2021 • edited Loading

Rick-Anderson commented Oct 21, 2021

davidfowl Oct 22, 2021

Choose a reason for hiding this comment

Rick-Anderson commented Oct 23, 2021

Rick-Anderson commented Oct 23, 2021

serpent5 left a comment • edited Loading

Choose a reason for hiding this comment

serpent5 Oct 25, 2021

Choose a reason for hiding this comment

serpent5 Oct 25, 2021 • edited Loading

Choose a reason for hiding this comment

Rick-Anderson commented Aug 3, 2021 •

edited

Loading

Rick-Anderson commented Oct 18, 2021 •

edited

Loading

serpent5 left a comment •

edited

Loading

serpent5 Oct 25, 2021 •

edited

Loading