Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and Edit build time OpenAPI/ra/b #33361
Fix and Edit build time OpenAPI/ra/b #33361
Changes from 62 commits
df65929
42711fc
1649587
446a579
f6ea15c
d1f346d
acd7cb8
a9dcecf
b074ef6
450f254
ce6735f
82d8440
29b0b19
30cb83d
aa7a993
691ddd0
967964b
7207787
830bd95
bf29769
f8c51cb
03444b0
bc64f73
8acbf92
f54bd9d
1b04232
b21f9f5
81fc99a
1a1766d
808fbb5
21e62a2
ee50266
9f95b57
b5d98ea
419d0f6
feebbda
b6469ca
38ecacb
739dcb5
52d682a
d298ace
854f69a
67c2271
0601997
df90ae3
8b6a7d5
2befcb7
025d0dc
101ac83
94bf18e
4f0bc88
a52ff1e
62e3480
078a6a6
e575f9a
3365563
49b9864
0cfbe8b
dd69fe2
7b320ba
6200d10
3dc0d25
ff894ff
5b87bda
3e4eca5
ecc1640
e607a14
c6cee5f
b798c9a
8a0df43
6276727
7af037a
6711ec1
82ddc0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is obj right? I would have thought it would be in the output directory (or should be) so be within bin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@captainsafia
drafted this as the output directory and maybe that's where it will end up. In my testing, it's in theobj
directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run /TestScripts/combined.ps1
what version of RC1 do you have?
I have 9.0.100-rc.1.24415.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My testing also shows that the default location is the obj directory, but you can change that (and I always do) with this setting in the project file:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't what I've seen in my testing. I get something like
ProjectName_DocumentName.json
(e.g.API_v1.json
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My build is 9.0.100-rc.1.24415.1
run /TestScripts/combined.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martincostello can you provide the code to demonstrate To prevent these code paths from being invoked by the build-time generation pipeline, they can be conditioned behind a check of the entry assembly: ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rick-Anderson I can take care of providing the code sample for this. I'll have to take a look at it next week.