Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WN: SignalR distributed tracing: Pre-work moving as is to include #33547

Merged

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Sep 5, 2024

Contributes to #33546

This is just the pre-work of moving the content as-is from the Product Unit into an include that is easier to diff from once I edit it.


Internal previews

📄 File 🔗 Preview link
aspnetcore/release-notes/aspnetcore-9.0.md What's new in ASP.NET Core 9.0

@wadepickett wadepickett self-assigned this Sep 5, 2024
@wadepickett wadepickett marked this pull request as ready for review September 5, 2024 23:24
@wadepickett
Copy link
Contributor Author

wadepickett commented Sep 5, 2024

[Update: Please disregard, I went ahead and combined the two ActivitySource sections and will open a new PR after that for edits.]

BrennanConroy, this is just a prep for moving your original content to an include for the What's New before I do an edit and move inline code to a project and link it back in.

However, it looked like I should combine the new SignalR client ActivitySource and previous server ActivitySource into one section. I have not edited yet, basically just added those two sections under one parent section. Does that generally look OK? If so I will merge this, and then you will see a diff in the next PR for any edit changes I make if needed. Thanks.

@wadepickett
Copy link
Contributor Author

I will go ahead and combine the two ActivitySource sections into one grouping and merge, then create a new PR to edit and move the code out to a project and link back in.

This PR was just prep only so we have something to diff against for edit.

@wadepickett wadepickett merged commit 643ef5c into main Sep 6, 2024
3 checks passed
@wadepickett wadepickett deleted the wadepickett/333442WhatNewSignalRdistributedTracing branch September 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant