-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use coalesce instead of join #1882
use coalesce instead of join #1882
Conversation
Templates were updated in #2338. Is this still relevant? Also, what does coalesce do? I'm not familiar with the templates. @askazakov cc @YegorStepanov |
Yes, it is still relevant. It's nothing but refactoring. Try to do a little bit more clean code. Docs for pr logic is something like
|
237dbad
to
db482b4
Compare
@timcassell @YegorStepanov any updates? |
Yegor is currently busy, he should be available to review this soon. |
@timcassell @YegorStepanov any updates? |
@AndreyAkinshin Perhaps you could give this a look if @YegorStepanov isn't around? |
db482b4
to
86913d1
Compare
@askazakov thanks for the PR and sorry for such a late merge. |
simplify template.json