Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors with latest sdk #2433

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix build errors with latest sdk #2433

merged 1 commit into from
Sep 22, 2023

Conversation

timcassell
Copy link
Collaborator

No description provided.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which package that we use has known critical vulnerability? Do we have to use it?

@timcassell
Copy link
Collaborator Author

timcassell commented Sep 22, 2023

It's netcoreapp2.0, the oldest core runtime we support. It's only used in manual tests, so it shouldn't be a concern for us.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @timcassell !

@timcassell timcassell merged commit 967a975 into master Sep 22, 2023
12 checks passed
@timcassell timcassell deleted the fix-build-errors branch September 22, 2023 21:36
@AndreyAkinshin AndreyAkinshin added this to the v0.13.9 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants