Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Event Processors not being copied in ManualConfig.Add #2434

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix Event Processors not being copied in ManualConfig.Add #2434

merged 1 commit into from
Sep 22, 2023

Conversation

caaavik-msft
Copy link
Contributor

Also add params support for AddEventProcessor to be consistent with other addable things.

This addresses additional feedback from @mawosoft on the previous PR: #2420 (comment)

adamsitnik
adamsitnik approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @caaavik-msft !

@adamsitnik adamsitnik merged commit 8227bbf into dotnet:master Sep 22, 2023
6 of 7 checks passed
@adamsitnik adamsitnik added this to the v0.13.9 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
Area:Loggers
Projects
None yet
Milestone
v0.13.9
Development

Successfully merging this pull request may close these issues.
3 participants
@caaavik-msft @adamsitnik @timcassell