Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation for SQL Server string.IsNullOrWhitespace #3461

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

roji
Copy link
Member

@roji roji commented Oct 3, 2021

Closes #3462

We could document that the translation changed across versions, but I honestly don't think it's worth it.

@roji roji requested a review from a team October 3, 2021 11:10
@bricelam
Copy link
Contributor

bricelam commented Oct 4, 2021

We could document that the translation changed across versions, but I honestly don't think it's worth it.

Agreed, a few other translations listed here were also different in previous releases. (Heck, some of them are straight up oversimplifications of the actual translation. It's more of a concept map between SQL and .NET)

@roji roji merged commit 96142cc into dotnet:main Oct 4, 2021
@roji roji deleted the IsNullOrWhitespace branch October 22, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs out of date for SQL Server translation of IsNullOrWhiteSpace
2 participants