Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multitenancy #3632

Merged
merged 19 commits into from
Mar 7, 2022
Merged

Conversation

JeremyLikness
Copy link
Member

Add document describing how to support multi-tenant databases. Fixes #3589.

@JeremyLikness JeremyLikness requested a review from a team December 17, 2021 19:12
Add multi-schema example per @roji feedback.
Removed trailing spaces
@roji
Copy link
Member

roji commented Dec 22, 2021

BTW consider linking to this page from the global query filters doc page.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JeremyLikness, here are some comments.

entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
entity-framework/core/miscellaneous/multitenancy.md Outdated Show resolved Hide resolved
@JeremyLikness
Copy link
Member Author

@roji I added the samples and will do the document updates once we are agreed the samples are correct. Please let me know. /cc @dotnet/efteam

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JeremyLikness, here's a first round of comments.

entity-framework/toc.yml Show resolved Hide resolved
samples/core/Multitenancy/.gitignore Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplemulti/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplemulti/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplemulti/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplesingle/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplesingle/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplesingle/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplesingle/Program.cs Outdated Show resolved Hide resolved
samples/core/Multitenancy/examplesingle/Program.cs Outdated Show resolved Hide resolved
@JeremyLikness
Copy link
Member Author

@roji I updated the samples, there are two (single db, multi-db). Please review and I'll update the markdown when the code is ready. Thanks!

@JeremyLikness JeremyLikness requested review from roji and a team March 1, 2022 17:17
@JeremyLikness
Copy link
Member Author

Made a pass at all recommendations. This is ready for review.

Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's great to see this guidance finally included in our docs!

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sheep eeeeeet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants