-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multitenancy #3632
Add multitenancy #3632
Conversation
Add multi-schema example per @roji feedback.
Removed trailing spaces
BTW consider linking to this page from the global query filters doc page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JeremyLikness, here are some comments.
@roji I added the samples and will do the document updates once we are agreed the samples are correct. Please let me know. /cc @dotnet/efteam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JeremyLikness, here's a first round of comments.
@roji I updated the samples, there are two (single db, multi-db). Please review and I'll update the markdown when the code is ready. Thanks! |
Made a pass at all recommendations. This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's great to see this guidance finally included in our docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sheep eeeeeet
Add document describing how to support multi-tenant databases. Fixes #3589.