Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR builds #163

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix PR builds #163

merged 1 commit into from
Sep 19, 2023

Conversation

tmeschter
Copy link
Contributor

The PR builds for dotnet/NuGet.BuildTasks are currently broken because the build pool we've specified, NetCore1ESPool-Public, doesn't actually exist. Here we make the following fixes to try and get it running again:

  1. Update the comment to point to the correct pipeline under https://dev.azure.com/dnceng-public.
  2. Update the build pool name to something that actually exists, and the demands to require a newer version of VS. These values both come from the PR build used for dotnet/project-system.

The PR builds for dotnet/NuGet.BuildTasks are currently broken because the build pool we've specified, NetCore1ESPool-Public, doesn't actually exist. Here we make the following fixes to try and get it running again:

1. Update the comment to point to the correct pipeline under https://dev.azure.com/dnceng-public.
2. Update the build pool name to something that actually exists, and the demands to require a newer version of VS. These values both come from the PR build used for dotnet/project-system.
@adamint
Copy link
Member

adamint commented Sep 19, 2023

Update the build pool name to something that actually exists

Lol

@tmeschter tmeschter merged commit 8b6df36 into dotnet:main Sep 19, 2023
4 checks passed
@tmeschter tmeschter deleted the 230919-FixPRBuild branch September 19, 2023 21:36
adamint pushed a commit that referenced this pull request Sep 24, 2024
adamint pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants