Change commentextensionlist ext element to 2006/main namespace #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomjebo
commented
Jul 22, 2024
tomjebo
commented
- fixes Found OpenXmlUnknownElement instead of CommentPropertiesExtension #1751
twsouthwick
reviewed
Jul 23, 2024
| /// <item><description>corresponds to the following strongly-typed classes: CommentPropertiesExtension.</description></item> | ||
| /// </list> | ||
| /// </remarks> | ||
| public static readonly XName ext = p188 + "ext"; |
There was a problem hiding this comment.
public partial class ....
{
[Obsolete("This is invalid for the namespace - use .... instead")]
public static readonly XName ext = p188 + "ext";
}
twsouthwick
reviewed
Jul 23, 2024
| @@ -1188,95 +1192,6 @@ internal override void ConfigureMetadata(ElementMetadata.Builder builder) | |||
| public override OpenXmlElement CloneNode(bool deep) => CloneImp<Comment>(deep); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
namespace ....;
{
[Obsolete("use ... instead", error: true)]
public partial class CommentPropertiesExtension: DocumentFormat.OpenXml.Presentation.CommentPropertiesExtension
{
... [ constructors ]
}
}
twsouthwick
previously approved these changes
Jul 24, 2024
src/DocumentFormat.OpenXml/Schema/Presentation/CommentPropertiesExtension.cs
Show resolved
Hide resolved
mikeebowen
approved these changes
Jul 24, 2024
mikeebowen
approved these changes
Jul 24, 2024
twsouthwick
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.