-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/decho/update identity templates #1323
Conversation
src/VS.Web.CG.Mvc/Templates/Identity/Bootstrap3/Pages/Account/Account.ExternalLogin.cs.cshtml
Show resolved
Hide resolved
...c/Templates/Identity/Bootstrap3/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
...c/Templates/Identity/Bootstrap3/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
...mplates/Identity/Bootstrap3/Pages/Account/Manage/Account.Manage.ResetAuthenticator.cs.cshtml
Outdated
Show resolved
Hide resolved
...lates/Identity/Bootstrap3/Pages/Account/Manage/Account.Manage.TwoFactorAuthentication.cshtml
Outdated
Show resolved
Hide resolved
src/VS.Web.CG.Mvc/Templates/Identity/Bootstrap4/Pages/Account/Account.ExternalLogin.cs.cshtml
Outdated
Show resolved
Hide resolved
...c/Templates/Identity/Bootstrap4/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
...mplates/Identity/Bootstrap4/Pages/Account/Manage/Account.Manage.ResetAuthenticator.cs.cshtml
Outdated
Show resolved
Hide resolved
src/VS.Web.CG.Mvc/Templates/Identity/Bootstrap4/Pages/Account/Account.ExternalLogin.cs.cshtml
Outdated
Show resolved
Hide resolved
...c/Templates/Identity/Bootstrap4/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
...c/Templates/Identity/Bootstrap4/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
...c/Templates/Identity/Bootstrap4/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
...mplates/Identity/Bootstrap4/Pages/Account/Manage/Account.Manage.ResetAuthenticator.cs.cshtml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the risk of doing all of these changes at once, is need to verify that the pages still work/compile, although I guess we do have CTI coverage that will pick up these bits right?
Yes will be testing manually a bunch and CTI will run scenarios. There are no compile issues with these updates. |
...c/Templates/Identity/Bootstrap3/Pages/Account/Manage/Account.Manage.ExternalLogins.cs.cshtml
Outdated
Show resolved
Hide resolved
* updated identity templates(cshtml and cshtml.cs) * updating bootstrap 3 identity templates * reverting some identity templates * reverting twofactorauth template * pr comment template fixes * small revert in bootstrap 3 template * nit remove line
* Dev/decho/update identity templates (#1323) * updated identity templates(cshtml and cshtml.cs) * updating bootstrap 3 identity templates * reverting some identity templates * reverting twofactorauth template * pr comment template fixes * small revert in bootstrap 3 template * nit remove line * Removed duplicated instruction from NoCodeGeneratorsFound (#1320) * Razor page namespace fix (#1326) * fixing razorpage namespace for the cli tool * including folder path now * adding dotnet-tools for missing packages (#1331) * Update jQuery in Identity scaffolding to v3.5.1 (#1328) Fixes #1327 Co-authored-by: Alfred Myers <[email protected]> Co-authored-by: Christian Wenz <[email protected]>
updated all discrepancies in identity templates using https://github.com/dotnet/aspnetcore/blob/master/src/Identity/UI/src/Areas/Identity/Pages.
Updated both bootstrap 3 and 4 templates.