Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/decho/update identity templates #1323

Merged
merged 7 commits into from
Apr 24, 2020

Conversation

deepchoudhery
Copy link
Member

updated all discrepancies in identity templates using https://github.com/dotnet/aspnetcore/blob/master/src/Identity/UI/src/Areas/Identity/Pages.

Updated both bootstrap 3 and 4 templates.

@deepchoudhery deepchoudhery requested a review from HaoK April 23, 2020 20:54
@deepchoudhery deepchoudhery requested a review from HaoK April 24, 2020 17:51
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the risk of doing all of these changes at once, is need to verify that the pages still work/compile, although I guess we do have CTI coverage that will pick up these bits right?

@deepchoudhery
Copy link
Member Author

deepchoudhery commented Apr 24, 2020

Yes will be testing manually a bunch and CTI will run scenarios.

There are no compile issues with these updates.

@deepchoudhery deepchoudhery merged commit 1ab2cdf into master Apr 24, 2020
@deepchoudhery deepchoudhery deleted the dev/decho/updateIdentityTemplates branch May 8, 2020 23:17
deepchoudhery added a commit that referenced this pull request May 11, 2020
* updated identity templates(cshtml and cshtml.cs)

* updating bootstrap 3 identity templates

* reverting some identity templates

* reverting twofactorauth template

* pr comment template fixes

* small revert in bootstrap 3 template

* nit remove line
deepchoudhery added a commit that referenced this pull request May 11, 2020
* Dev/decho/update identity templates (#1323)

* updated identity templates(cshtml and cshtml.cs)

* updating bootstrap 3 identity templates

* reverting some identity templates

* reverting twofactorauth template

* pr comment template fixes

* small revert in bootstrap 3 template

* nit remove line

* Removed duplicated instruction from NoCodeGeneratorsFound (#1320)

* Razor page namespace fix (#1326)

* fixing razorpage namespace for the cli tool

* including folder path now

* adding dotnet-tools for missing packages (#1331)

* Update jQuery in Identity scaffolding to v3.5.1 (#1328)

Fixes #1327

Co-authored-by: Alfred Myers <[email protected]>
Co-authored-by: Christian Wenz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants