Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline #2181

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Fix newline #2181

merged 1 commit into from
Dec 29, 2022

Conversation

zahalzel
Copy link
Contributor

Adds newline for the output resulting from modifying code files

Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zahalzel zahalzel merged commit 3c94fb8 into main Dec 29, 2022
@deepchoudhery deepchoudhery deleted the dev/zahalzel/code_file_newline branch January 3, 2023 18:18
deepchoudhery pushed a commit that referenced this pull request Jan 4, 2023
deepchoudhery added a commit that referenced this pull request Jan 6, 2023
* output error for app registrations, and formatting nit (#2129)

* Fix output for app registrations (#2144)

Adding issue: #2146

* Log token authentication failure to JsonResponse, Refactor getting app registrations (#2149)

* Refactor getting app registrations

* Fix test

* Refactor ConsoleLogger failure logging

* Fix newline (#2181)

* bumping dotnet-msidentity version

* Refactor console logger and catch app provisioning exceptions (#2189)

* Refactor console logger

* Exit environment after logging failure

* Add try/catch to app registration creation

* Refactor LogFailure to LogFailureAndExit

Co-authored-by: Zachary Halzel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants