Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication bug (regenerate msal.cache) #2210

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

zahalzel
Copy link
Contributor

@zahalzel zahalzel commented Jan 9, 2023

The tool has been relying on Visual Studio to populate or create the msal.cache file for storing account information, but since VS has transitioned to using WAM it no longer populates the msal.cache file. To work around this, we can make a call to AcquireTokenInteractive when an account is not found, and this will pop up a browser window allowing for picking an account.

Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zahalzel zahalzel merged commit 9e56e9b into main Jan 9, 2023
@zahalzel zahalzel deleted the dev/zahalzel/msal_cache_fix branch January 9, 2023 20:16
deepchoudhery pushed a commit that referenced this pull request Jan 9, 2023
* Prototyping msal cache fixes

* Refactor get authentication

* Refactor method signature
deepchoudhery added a commit that referenced this pull request Jan 9, 2023
* add database providers for ef scenarios (#2139)

* init

* add DbType enum

* postgres changes work now

* changed DatabaseType to DatabaseProvider.

* adding --useSqlite|-sqlite validation.

* added unit test plus cleanup

* minor fix

* minor edits and refactors.

* minor fix.

* final fixes for now oof.

* minor fix again.

* Fix authentication bug (regenerate msal.cache) (#2210)

* Prototyping msal cache fixes

* Refactor get authentication

* Refactor method signature

* update aspnet-codegenerator to 7.0.2

Co-authored-by: Zachary Halzel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants