Moving patch fixes from placeholder branch to rel/2.0.1 #626
Conversation
|
Adding @natemcmaster and @JunTaoLuo to review and to make sure the patch infrastructure sees this branch. |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="..\Shared.proj" /> | ||
| <PropertyGroup> | ||
| <RuntimeIdentifier>win-arm</RuntimeIdentifier> |
There was a problem hiding this comment.
Have you tried using just one csproj instead? You can specified multiple RIDs in one file.
<RuntimeIdentifiers>win-arm;win-arm64;win7-x86</RuntimeIdentifiers>
There was a problem hiding this comment.
Wasn't able to get it to work with RuntimeIdentifiers. Don't recall exactly what the problem was at the time.
There was a problem hiding this comment.
That's fine. Was just wondering if you were aware this was an option.
| @@ -0,0 +1,17 @@ | |||
| <Project> | |||
There was a problem hiding this comment.
Nit: it's MSBuild convention use the .props extension instead of .proj. This file is only intended to be used via Import, and not invoked directly.
|
We should be ok on infrastructure. Universe is already set to build rel/2.0.1 of this repo. |
when CI is green
|
AppVeyor is failing to build Known issue? |
Issues addressed (along with the approved PRs) :
#587 --> #597
#588 --> #596
#601 --> #605
cc @Eilon @mlorbetske