-
Notifications
You must be signed in to change notification settings - Fork 286
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improved Sql bulk copy error message (#437)
- Loading branch information
1 parent
ba84cf0
commit 0dc60ad
Showing
18 changed files
with
508 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 10 additions & 1 deletion
11
src/Microsoft.Data.SqlClient/netcore/src/Resources/SR.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 10 additions & 1 deletion
11
src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Data; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted | ||
| { | ||
| /// <summary> | ||
| /// Always Encrypted public API Manual tests. | ||
| /// TODO: These tests are marked as Windows only for now but should be run for all platforms once the Master Key is accessible to this app from Azure Key Vault. | ||
| /// </summary> | ||
| [PlatformSpecific(TestPlatforms.Windows)] | ||
| public class BulkCopyAEErrorMessage : IClassFixture<SQLSetupStrategyCertStoreProvider> | ||
| { | ||
| private SQLSetupStrategyCertStoreProvider _fixture; | ||
|
|
||
| private readonly string _tableName; | ||
| private readonly string _columnName; | ||
|
|
||
| public BulkCopyAEErrorMessage(SQLSetupStrategyCertStoreProvider fixture) | ||
| { | ||
| _fixture = fixture; | ||
| _tableName = fixture.BulkCopyAEErrorMessageTestTable.Name; | ||
| _columnName = "c1"; | ||
| } | ||
|
|
||
| [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringSetupForAE))] | ||
| [ClassData(typeof(AEConnectionStringProvider))] | ||
| public void TextToIntErrorMessageTest(string connectionString) | ||
| { | ||
| string value = "stringValue"; | ||
| DataTable dataTable = CreateDataTable(value); | ||
|
|
||
| Assert.True(StringToIntTest(connectionString, _tableName, dataTable, value, dataTable.Rows.Count), "Did not get any exceptions for DataTable when converting data from 'string' to 'int' datatype!"); | ||
| Assert.True(StringToIntTest(connectionString, _tableName, dataTable.Select(), value, dataTable.Rows.Count),"Did not get any exceptions for DataRow[] when converting data from 'string' to 'int' datatype!"); | ||
| Assert.True(StringToIntTest(connectionString, _tableName, dataTable.CreateDataReader(), value, -1),"Did not get any exceptions for DataReader when converting data from 'string' to 'int' datatype!"); | ||
| } | ||
|
|
||
| private DataTable CreateDataTable(string value) | ||
| { | ||
| var dataTable = new DataTable(); | ||
| dataTable.Columns.Add(_columnName, typeof(string)); | ||
|
|
||
| var dataRow = dataTable.NewRow(); | ||
| dataRow[_columnName] = value; | ||
| dataTable.Rows.Add(dataRow); | ||
| dataTable.AcceptChanges(); | ||
|
|
||
| return dataTable; | ||
| } | ||
|
|
||
| private bool StringToIntTest(string connectionString, string targetTable, object dataSet, string value, int rowNo, string targetType = "int") | ||
| { | ||
| var encryptionEnabledConnectionString = new SqlConnectionStringBuilder(connectionString) | ||
| { | ||
| ColumnEncryptionSetting = SqlConnectionColumnEncryptionSetting.Enabled | ||
| }.ConnectionString; | ||
|
|
||
| bool hitException = false; | ||
| try | ||
| { | ||
| using (var connection = new SqlConnection(encryptionEnabledConnectionString)) | ||
| using (var bulkCopy = new SqlBulkCopy(connection) | ||
| { | ||
| EnableStreaming = true, | ||
| BatchSize = 1, | ||
| DestinationTableName = "[" + _tableName + "]" | ||
| }) | ||
| { | ||
| connection.Open(); | ||
| bulkCopy.ColumnMappings.Add(new SqlBulkCopyColumnMapping(0, 0)); | ||
|
|
||
| if (dataSet as DataTable != null) | ||
| { | ||
| bulkCopy.WriteToServer((DataTable)dataSet); | ||
| } | ||
| if (dataSet as DataRow[] != null) | ||
| { | ||
| bulkCopy.WriteToServer((DataRow[])dataSet); | ||
| } | ||
| if (dataSet as IDataReader != null) | ||
| { | ||
| bulkCopy.WriteToServer((IDataReader)dataSet); | ||
| } | ||
| } | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| string pattern; | ||
| object[] args = | ||
| new object[] { string.Empty, value.GetType().Name, targetType, 0, _columnName, rowNo }; | ||
| if (rowNo == -1) | ||
| { | ||
| Array.Resize(ref args, args.Length - 1); | ||
| pattern = SystemDataResourceManager.Instance.SQL_BulkLoadCannotConvertValueWithoutRowNo; | ||
| } | ||
| else | ||
| { | ||
| pattern = SystemDataResourceManager.Instance.SQL_BulkLoadCannotConvertValue; | ||
| } | ||
|
|
||
| string expectedErrorMsg = string.Format(pattern, args); | ||
|
|
||
| Assert.True(ex.Message.Contains(expectedErrorMsg), "Unexpected error message: " + ex.Message); | ||
| hitException = true; | ||
| } | ||
| return hitException; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.