SqlException.CreateException throws NullReferenceException when no batch

[kamilkulczyk]

SqlException.CreateException calls for command?.GetCurrentBatchCommand()) even if there's no batch

While switching from (1) System.Data.SqlClient to (2) Microsoft.Data.SqlClient I got an error caused by this change of code:

1. SqlException exc = SqlException.CreateException(sqlErs, serverVersion, _connHandler);
2. SqlException exc = SqlException.CreateException(sqlErs, serverVersion, _connHandler, innerException:null, batchCommand: command?.GetCurrentBatchCommand();

An error occurs when ExecuteNonQuery() a script that has a "caution" message and FireInfoMessageEventOnUserErrors = true. My Script uses SP_RENAME and has "Caution: Changing any part of an object name could break scripts and stored procedures." message.

SqlException.CreateException() => command?.GetCurrentBatchCommand() =>return _rpcArrayOf1[0].batchCommand, where _rpcArrayOf1 is null, cause never initialized. That throws NullReferenceException.

To reproduce

0. C# .NET 8 with Microsoft.Data.SqlClient
1. Simple script with SP_RENAME
2. FireInfoMessageEventOnUserErrors = true
3. ExecuteNonQuery()

Expected behavior

I'd like to be able to execute a script with FireInfoMessageEventOnUserErrors = true, even if it's not a batch.

Is that an error or do I miss something?

[fr4gles]

Same issue reported here #2388

[JRahnama]

@kamilkulczyk Thank you for reaching out. We will update you on the investigation results.

[kamilkulczyk]

@JRahnama I assume that if #2388 is closed this is as well?

[JRahnama]

@kamilkulczyk thanks for reminding me.

Closing as this is addressed in PR #2399