-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | The SqlConnection.FireInfoMessageEventOnUserErrors when set to true throws an exception #2399
Fix | The SqlConnection.FireInfoMessageEventOnUserErrors when set to true throws an exception #2399
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
==========================================
- Coverage 72.71% 66.84% -5.87%
==========================================
Files 310 304 -6
Lines 61885 61576 -309
==========================================
- Hits 44997 41158 -3839
- Misses 16888 20418 +3530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandFireInfoMessageEventOnUserErrorsTest.cs
Outdated
Show resolved
Hide resolved
The proposed fix seems satisfactory for merging as it stands. However, it's important to note that this portion of the code was altered by #1825. Given that it introduces a new feature to the driver, it's essential to conduct a thorough review to ensure that the implementation behaves as intended in this particular scenario. cc: @Wraith2 |
Fix the title with a proper description, please. |
I'm intrigued. How have we managed to have to reach |
I am curious to understand why |
If there is never a way to call the caller of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I debugged through it and understand the situation now. The library only needs to use an RPC object internally if there are parameters and in this case there aren't so it follows a path that simply sends the text without first building any sort of RPC. It'd be good to get this sort of breakdown as part of the fix so those of us following along at home can understand why the fix works. It does raise a question or what happens if you try to setup a BatchCommand with a set of commands that have no parameters, would errors be reported correctly or crash? |
… to true throws an exception (dotnet#2399)
Fixes #2388