-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include new packages in nuspec file #1266
Include new packages in nuspec file #1266
Conversation
DavoudEshtehari
commented
Sep 20, 2021
•
edited
Loading
edited
- Alphabetically has been sorted.
4dd9c33
to
3a93cab
Compare
The following are present in netcore csproj but still missing in the changes:
Should we include every package? @cheenamalhotra |
Good observation, I could build netcore project without these packages included. |
d63acaf
to
ba8089b
Compare
All the pipelines passed without those 4 package references on .NET Core, yesterday. Updated |
You could consider building the nuget package using msbuild... |
that is how we build the driver and tests, if I have got your point correct. Building driver using |
That's our scripts doing all the work. I think @ErikEJ is referring to |
Yes, I meant define the package in the .csproj, this also makes dependency management much simpler |
Our process is distributed since we need to Sign the DLLs before packing when we build release packages. For that reason we build and pack in different steps, but we can investigate any possibilities to ease this process. |