Move into Shared for SqlCommandBuilder.cs

[lcheunglci]

Relates to #1261 . I merged the SqlCommandBuilder.cs from netfx into netcore and then move it into the shared src. The netfx version uses System.ComponentModel and some attributes from it, which I assume were for WPF or WinForms and there were some DEBUG ifdefs, so I ifdef'ed them for NETFX.

[Wraith2]

I'm pretty sure we want the designer attributes in all builds. The difference may have come from the early version of netcore not having those attributes but since we don't support anything before 3.1 now if those attributes are present we should keep them.

The only problem you might have is if the resources they use are localized and in that case we'll have to see what the MS team want to do, I know there's a long term goal for getting the netfx localized resources working in netcore.

[lcheunglci]

That's good to know. In that case, I should wait for #1272 and merge those in this PR before I remove the ifdefs for the designer attributes

[Wraith2]

It'll depend on the attribute, if you check them on apisof.net for example DesignerSerializationVisibilityAttribute you can see it's in NS2.0 and netcore 2 onwards so it should be ok to do now. Perhaps just take out the iffdefs locally and see if it compiles?

[lcheunglci]

Thanks @Wraith2 , it looks like majority of the attributes builds fine with the exception of ResDescriptionAttribute(StringsHelper.ResourceNames.SqlCommandBuilder_DataAdapter) where the string doesn't exist in the StringHelper in the netcore project. I wonder if it's ok to copy it out of the Strings.resx from netfx as a string literal or should I leave it with the ifdef NETFX

[Wraith2]

Hmm, have a look at #1152 and see if there's any precedent there that can help. I'd say just add the resource.