Use Buffer.BlockCopy with byte[] #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is based on changes done dotnet/corefx@3ab3bd6. I have replaced Array.Copy wherever there is byte[]. Buffer.BlockCopy has less overhead than Array.Copy when copying byte[]s.
|
I don't object but I also don't think this will make any measurable difference to performance. |
It is debatable at many resources if there is performance difference or not. I have added this to diverge the difference between netfx and netcore and to be consistent across all files, responding to the comment #1337 (comment) |
cheenamalhotra
added
the
➕ Code Health
Kaur-Parminder
requested review from
DavoudEshtehari,
johnnypham and
JRahnama
johnnypham
approved these changes
Jan 18, 2022
DavoudEshtehari
approved these changes
Jan 21, 2022
|
working with bytes are more difficult than working with indexes and may cause debugging to be more complicated, but since the data is already in bytes no issue here. Looks good to me. |
JRahnama
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is based on changes done dotnet/corefx@3ab3bd6. I have replaced Array.Copy wherever there is byte[]. Buffer.BlockCopy has less overhead than Array.Copy when copying byte[]s.