[Hotfix 4.1.1] | Parallelize SSRP requests when MSF is specified (#1578) #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
requested review from
David-Engel,
lcheunglci,
JRahnama and
Kaur-Parminder
| @@ -21,8 +24,11 @@ internal class SSRP | |||
| /// </summary> | |||
There was a problem hiding this comment.
Not related to the ported PR, this class is sealed in other branch.
There was a problem hiding this comment.
It's sealed in the main branch by #1430. For backporting, we should consider a PR from the main branch to keep track of the changes. In my opinion, this is a helper class with static members only and we can avoid this amendment.
David-Engel
approved these changes
Aug 12, 2022
JRahnama
approved these changes
Aug 12, 2022
lcheunglci
approved these changes
Aug 15, 2022
|
/azp run |
|
No pipelines are associated with this pull request. |
DavoudEshtehari
force-pushed
the
Backport/4.1.1-ParallelizeSSRP
branch
from
acf6aef
to
f9a6465
Compare
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SSRP.cs
DavoudEshtehari
force-pushed
the
Backport/4.1.1-ParallelizeSSRP
branch
from
f9a6465
to
d93f8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #1578