-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | AE enclave retry logic not working for async queries #1988
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
==========================================
+ Coverage 70.46% 70.60% +0.13%
==========================================
Files 306 306
Lines 61563 61800 +237
==========================================
+ Hits 43382 43634 +252
+ Misses 18181 18166 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 48 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
...ft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlColumnEncryptionEnclaveProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
doc/snippets/Microsoft.Data.SqlClient/SqlColumnEncryptionEnclaveProvider.xml
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
Show resolved
Hide resolved
…async queries (dotnet#1988) Ports [dotnet#1988](dotnet#1988)
…async queries (dotnet#1988) Ports [dotnet#1988](dotnet#1988)
…async queries (dotnet#1988) Ports [dotnet#1988](dotnet#1988)
This should address intermittent failures related to #1422
Summary:
The retry logic when a cached enclave session expired (8 hours) doesn't look like it was implemented properly for async queries. There were several problems.
Enclave session is null during query execution.
errors. If the session cache entry expired at just the right time, the retry logic path would not even be hit.