Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

Merged
merged 25 commits into from
Jul 6, 2023
Merged

Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

merged 25 commits into from
Jul 6, 2023

Commits on Jun 8, 2023

  1. Add SqlConnectionEncryptOptionConverter class which is used to conver… 

    …t string Encrypt option into SqlConnectionEncryptionOption type.
    @arellegue
    arellegue committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    5c505a1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/arellegue/SqlClient

    @arellegue
    arellegue committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    9b9af7e View commit details
    Browse the repository at this point in the history

  3. Removed added blank line.

    @arellegue
    arellegue committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4ebaabd View commit details
    Browse the repository at this point in the history

  4. Removed redundant InLineData from ConnectionStringFromJsonTests.

    @arellegue
    arellegue committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    39a7ea8 View commit details
    Browse the repository at this point in the history

  5. Fix issues found in PR request.

    @arellegue
    arellegue committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    0a0768e View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Changed SqlConnectionEnryptOptionConverter from public to internal.

    @arellegue
    arellegue committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ab6a469 View commit details
    Browse the repository at this point in the history

  2. Applied Davoud's suggestions for changes.

    @arellegue
    arellegue committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    892625c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Update src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnecti… 

    …onStringBuilderTest.cs
    @DavoudEshtehari
    DavoudEshtehari authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    789670e View commit details
    Browse the repository at this point in the history

  2. Update tools/props/Versions.props

    @DavoudEshtehari
    DavoudEshtehari authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5455314 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Add more SqlConnectionEncryptOptionConverter unit tests.

    @arellegue
    arellegue committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e07547a View commit details
    Browse the repository at this point in the history

  2. Add assessment of exception thrown in ExecuteConnectionStringFromJson… 

    …ThrowsException unit test.
    @arellegue
    arellegue committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7197981 View commit details
    Browse the repository at this point in the history

  3. Added blank line.

    @arellegue
    arellegue committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d7f0058 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Apply suggestions from code review

    @DavoudEshtehari
    DavoudEshtehari authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7dee649 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary XML file for internal class SqlConnectionEncryptO… 

    …ptionConverter.

Removed misplaced region.
Removed function that is not used.
    @arellegue
    arellegue committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c9d115c View commit details
    Browse the repository at this point in the history

  3. Use ADP.ConvertFailed helper function in SqlConnectionEncryptOptionCo… 

    …nverter class.
    @arellegue
    arellegue committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4b5f86d View commit details
    Browse the repository at this point in the history

  4. Resolved merged conflict.

    @arellegue
    arellegue committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    14ac22f View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @DavoudEshtehari
    DavoudEshtehari authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9a42b07 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Add message to show more information if CanCanConvert returns false.

    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    809bbe8 View commit details
    Browse the repository at this point in the history

  2. Fixed grammar error in the message to show more information if CanCon… 

    …vertFrom test returns false.
    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    20170ee View commit details
    Browse the repository at this point in the history

  3. Removed entry for EncryptOptionConverter XML.

    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    06b3536 View commit details
    Browse the repository at this point in the history

  4. Revert "Removed entry for EncryptOptionConverter XML." 

    This reverts commit 06b3536.
    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    99d1243 View commit details
    Browse the repository at this point in the history

  5. Remove EncryptOptionConverter xml in MDS solution.

    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    766d859 View commit details
    Browse the repository at this point in the history

  6. Add more messages to show more information if CanConvertFrom and CanC… 

    …onvertTo returns false.
    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1040674 View commit details
    Browse the repository at this point in the history

  7. Change messages to show the expections when CanConvertFrom and CanCon… 

    …vertTo tests passed or failed.
    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    f54d699 View commit details
    Browse the repository at this point in the history

  8. Fix CanConvertTo messages.

    @arellegue
    arellegue committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7415ec1 View commit details
    Browse the repository at this point in the history