-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev | Add support of the new authentication API with SSPI token on Managed SNI #2063
Conversation
DavoudEshtehari
commented
Jun 15, 2023
•
edited
Loading
edited
- Consumed NegotiateAuthentication type on Managed SNI, which has been shipped with .net 7.0 and above.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
- Coverage 70.80% 69.90% -0.90%
==========================================
Files 305 305
Lines 61819 61943 +124
==========================================
- Hits 43770 43303 -467
- Misses 18049 18640 +591
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs
Show resolved
Hide resolved
@DavoudEshtehari This is great! Can we condition out the NET6-only files/classes/code related to the previous calls so that they aren't even compiled into the NET7+ binary? |