Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .NET and .NET Standard file version #2093

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

David-Engel
Copy link
Contributor

@David-Engel David-Engel commented Jul 20, 2023

This addresses issue #1945

The changes also allow us to pass a build number to the build script in the CI to properly version CI artifacts.

@David-Engel David-Engel changed the title Fix .NET and .NET standard file version Fix .NET and .NET Standard file version Jul 20, 2023
@David-Engel
Copy link
Contributor Author

/azp run CI-SqlClient

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3607fe2) 70.67% compared to head (9ba1748) 70.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2093   +/-   ##
=======================================
  Coverage   70.67%   70.68%           
=======================================
  Files         306      306           
  Lines       61995    61975   -20     
=======================================
- Hits        43816    43808    -8     
+ Misses      18179    18167   -12     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.44% <ø> (+0.03%) ⬆️
netfx 69.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari added 💡 Enhancement Issues that are feature requests for the drivers we maintain. 🐛 Bug! Issues that are bugs in the drivers we maintain. Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. and removed 💡 Enhancement Issues that are feature requests for the drivers we maintain. labels Jul 21, 2023
@David-Engel David-Engel merged commit 4c1b111 into dotnet:main Jul 21, 2023
@David-Engel David-Engel deleted the version branch July 21, 2023 17:11
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Oct 25, 2023
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Oct 27, 2023
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Oct 30, 2023
@dougwalden
Copy link

How do I make sure I get this corrected? I am using .net8 and trying to run my app in a Docker Container and getting the error:
Process Run Exception: Could not load file or assembly 'Microsoft.Data.SqlClient, Version=5.0.0.0, Culture=neutral, PublicKeyToken=23ec7fc2d6eaa4a5'. The system cannot find the file specified.

We are using Dev Azure pipeline to build the application and then deploy from there to our Docker Container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. 🐛 Bug! Issues that are bugs in the drivers we maintain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Version for Package Microsoft.Data.SqlClient 5.1 lists as 5.0
4 participants