Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip UDT query on Azure SQL Edge #2099

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jul 23, 2023

fixes #2086

Are there any manual tests against Azure SQl Edge?

Otherwise I can run a smoketest with the CI generated package

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.02 🎉

Comparison is base (a709006) 69.92% compared to head (e5380f2) 69.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2099      +/-   ##
==========================================
+ Coverage   69.92%   69.94%   +0.02%     
==========================================
  Files         306      306              
  Lines       61975    61980       +5     
==========================================
+ Hits        43335    43351      +16     
+ Misses      18640    18629      -11     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.39% <80.00%> (+0.02%) ⬆️
netfx 68.22% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/Microsoft/Data/SqlClient/SqlMetadataFactory.cs 92.00% <80.00%> (-0.50%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Aug 5, 2023

@MaceWindu @Kaur-Parminder I have tested the NuGet package from the pipeline, and I am able to run this without any errors using the Azure SQL Emulator Lite image (Azure SQL Edge)

SELECT SERVERPROPERTY('EngineEdition') returns 9

using Microsoft.Data.SqlClient;
using System.Data;

var connection = new SqlConnection(new SqlConnectionStringBuilder
{
    DataSource = "localhost,1436",    
    InitialCatalog = "Test",
    TrustServerCertificate = true,
    UserID = "sa",
    Password = "Pas$W0rd"}.ConnectionString);

connection.Open();

var result = connection.GetSchema("DataTypes");

foreach (DataRow row in result.Rows)
{
    Console.WriteLine($"{row["TypeName"]} - {row["DataType"]} - {row["ProviderDbType"]}");
}

@David-Engel David-Engel added this to the 5.2.0-preview4 milestone Aug 14, 2023
@David-Engel David-Engel merged commit 80905bd into dotnet:main Aug 15, 2023
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetSchema("DataType") is not compatible with Azure SQL Edge
3 participants