-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UWP (uap) references and special cased code #2483
Conversation
Some boy scouting on DataTestUtility
@ErikEJ personally, I support this pull request, but @David-Engel should include the conclusion. |
@JRahnama Of course! |
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
+ Coverage 72.68% 72.73% +0.04%
==========================================
Files 313 313
Lines 61727 61718 -9
==========================================
+ Hits 44867 44889 +22
+ Misses 16860 16829 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM, with just a minor adjustment. Thank you @ErikEJ . |
|
@JRahnama Which conflict? |
This is weird. I saw the conflict this morning 😆. Ignore my comment |
Some boy scouting on DataTestUtility (removed unused code)
fixes #2482