Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UWP (uap) references and special cased code #2483

Merged
merged 5 commits into from
May 7, 2024

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented May 5, 2024

Some boy scouting on DataTestUtility (removed unused code)

fixes #2482

Some boy scouting on DataTestUtility
@JRahnama
Copy link
Member

JRahnama commented May 5, 2024

@ErikEJ personally, I support this pull request, but @David-Engel should include the conclusion.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented May 5, 2024

@JRahnama Of course!

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.73%. Comparing base (48ab625) to head (5959602).
Report is 2 commits behind head on main.

❗ Current head 5959602 differs from pull request most recent head 554a88f. Consider uploading reports for the commit 554a88f to get more accurate results

Files Patch % Lines
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2483      +/-   ##
==========================================
+ Coverage   72.68%   72.73%   +0.04%     
==========================================
  Files         313      313              
  Lines       61727    61718       -9     
==========================================
+ Hits        44867    44889      +22     
+ Misses      16860    16829      -31     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 77.04% <94.11%> (+0.07%) ⬆️
netfx 70.43% <90.90%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@David-Engel David-Engel requested a review from JRahnama May 7, 2024 00:29
@David-Engel David-Engel added this to the 6.0-preview1 milestone May 7, 2024
@JRahnama
Copy link
Member

JRahnama commented May 7, 2024

LGTM, with just a minor adjustment. Thank you @ErikEJ .

@JRahnama
Copy link
Member

JRahnama commented May 7, 2024

@ErikEJ if you can address the conflict this is ready to merge.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented May 7, 2024

@JRahnama Which conflict?

@JRahnama
Copy link
Member

JRahnama commented May 7, 2024

@JRahnama Which conflict?

This is weird. I saw the conflict this morning 😆. Ignore my comment

@JRahnama JRahnama merged commit 4c0f013 into dotnet:main May 7, 2024
148 checks passed
@David-Engel David-Engel added the 🔨 Breaking Change Use this label for breaking API changes in the driver. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Breaking Change Use this label for breaking API changes in the driver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Remove uap/UWP references
3 participants