Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix | Fix issue with Socket.Connect in managed SNI (#2777) #2779

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Aug 15, 2024

Ports #2777

@JRahnama JRahnama added Ⓜ️ Managed SNI Use this label if the issue/PR relates to issues in Managed SNI 💥 Regression Regression introduced from earlier PRs labels Aug 15, 2024
@JRahnama JRahnama merged commit a1672c3 into dotnet:release/5.2 Aug 15, 2024
148 of 150 checks passed
@JRahnama JRahnama deleted the backport-socket-issue-to-5-2 branch August 15, 2024 23:13
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (ec5ad66) to head (4b9a0e2).
Report is 2 commits behind head on release/5.2.

Files Patch % Lines
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 57.14% 3 Missing ⚠️
...core/src/Microsoft/Data/SqlClient/SNI/SNICommon.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.2    #2779      +/-   ##
===============================================
- Coverage        72.64%   72.62%   -0.02%     
===============================================
  Files              310      310              
  Lines            61881    61930      +49     
===============================================
+ Hits             44953    44977      +24     
- Misses           16928    16953      +25     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.79% <63.63%> (-0.04%) ⬇️
netfx 70.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@David-Engel David-Engel changed the title [5.2] Fix | Fix the issue with Socke.Connect in managed SNI (#2777) [5.2] Fix | Fix issue with Socket.Connect in managed SNI (#2777) Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Regression Regression introduced from earlier PRs Ⓜ️ Managed SNI Use this label if the issue/PR relates to issues in Managed SNI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants